fix(ramps-controller): refresh countries catalog on app startup#9261
Open
amitabh94 wants to merge 6 commits into
Open
fix(ramps-controller): refresh countries catalog on app startup#9261amitabh94 wants to merge 6 commits into
amitabh94 wants to merge 6 commits into
Conversation
Stop persisting the countries catalog and force-refetch via init() so preset amounts stay in sync after app restarts. TRAM-3682 Co-authored-by: Cursor <cursoragent@cursor.com>
TRAM-3682 Co-authored-by: Cursor <cursoragent@cursor.com>
wenfix
force-pushed
the
fix/tram-3682-countries-catalog-refresh-on-start
branch
from
dae992f to
82c35e8
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 82c35e8. Configure here.
saustrie-consensys
left a comment
saustrie-consensys
left a comment
Contributor
There was a problem hiding this comment.
I left an important question before I can approve
| if (forceRefresh || !hasCountries) { | ||
| await this.getCountries(options); | ||
| } | ||
| await this.getCountries({ ...options, forceRefresh: true }); |
Contributor
There was a problem hiding this comment.
@amitabh94 @wenfix Why not simply use forceRefresh? We created that option for a reason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Stale persisted countries catalog data caused preset amounts (e.g. $100 / $250 / $500) to stay wrong after app restarts until the user changed region, even when the API had updated values.
This change is controller-only in
@metamask/ramps-controller— no MetaMask Mobile or portfolio changes.persist: false) so restarts do not reuse stale catalog data.init(), always refetch countries viagetCountries()(including whenuserRegionis already set).getCountries(), re-syncuserRegionpreset amounts from the fresh catalog via#syncUserRegionFromCountriesCatalog.Consumers need a new
@metamask/ramps-controllerrelease; mobile can pick it up via the usual Core dependency bump.References
Checklist
Made with Cursor